Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move black to pre-commit #246

Merged
merged 1 commit into from
Feb 3, 2025
Merged

ci: Move black to pre-commit #246

merged 1 commit into from
Feb 3, 2025

Conversation

auscompgeek
Copy link
Member

This intends to do two things:

  1. Pin the black version, so we don't get surprised by the annual black major release suddenly failing CI.
  2. Make it easier for first-time contributors to discover the formatters/linters we have, and make these checks easier to reproduce locally (e.g. pre-commit run --all-files).

Once this is in we can move the pre-commit job off of GitHub Actions (to avoid hitting concurrent runner limits) by using https://pre-commit.ci instead (which will also provide autoupdate PRs and autofixing).

@auscompgeek auscompgeek merged commit 7097b10 into main Feb 3, 2025
32 checks passed
@auscompgeek auscompgeek deleted the pre-commit branch February 3, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant